Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
wolf
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
mobile_robotics
wolf_projects
wolf_lib
wolf
Merge requests
!290
Resolve "ProcessorLoopClosureBase class"
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Resolve "ProcessorLoopClosureBase class"
220-processor-loop-closure-base
into
devel
Overview
6
Commits
23
Pipelines
2
Changes
2
Merged
Joan Vallvé Navarro
requested to merge
220-processor-loop-closure-base
into
devel
5 years ago
Overview
6
Commits
23
Pipelines
2
Changes
2
Expand
Closes
#220 (closed)
0
0
Merge request reports
Viewing commit
b9b18869
Prev
Next
Show latest version
2 files
+
8
−
8
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
b9b18869
ProcessorLoopClosureBase : manipulate captures instead of frames
· b9b18869
PierreGtch
authored
5 years ago
include/core/processor/processor_loopclosure_base.h
+
3
−
3
Options
@@ -96,19 +96,19 @@ protected:
* if validateLoop is not overwritten, a loop will be closed with the returned candidate
* if no good candidate is found, return nullptr
*/
virtual
Fram
eBasePtr
findLoopCandidate
(
Fram
eBasePtr
_
key_fram
e
)
=
0
;
virtual
Captur
eBasePtr
findLoopCandidate
(
Captur
eBasePtr
_
captur
e
)
=
0
;
/** \brief validate/discard a loop closure
*
* overwrite it if you want an additional test after findLoopCandidate()
*/
bool
validateLoop
(
Fram
eBasePtr
_
key_frame_1
,
Fram
eBasePtr
_
key_fram
e_2
)
{
return
true
;};
bool
validateLoop
(
Captur
eBasePtr
_
capture_1
,
Captur
eBasePtr
_
captur
e_2
)
{
return
true
;};
/** \brief create the factor(s)
*
* overwrite it if needed
*/
virtual
void
createFactors
(
Fram
eBasePtr
_
key_frame_1
,
Fram
eBasePtr
_
key_fram
e_2
)
=
0
;
virtual
void
createFactors
(
Captur
eBasePtr
_
capture_1
,
Captur
eBasePtr
_
captur
e_2
)
=
0
;
/** Pre-process incoming Capture
Loading