Resolve "ProcessorLoopClosureBase class"
Closes #220 (closed)
Merge request reports
Activity
Filter activity
68 /**\brief Add a pack to the buffer 69 * 70 */ 71 void add(const T& _element, const TimeStamp& _time_stamp); //const Scalar& _time_tolerance); 72 73 /**\brief Remove all packs in the buffer with a time stamp older than the specified 74 * 75 */ 76 void removeUpTo(const TimeStamp& _time_stamp); 77 78 /**\brief Clear the buffer 79 * 80 */ 81 void clear(); 82 83 /**\brief Empty the buffer Fixed in 66198eff
56 * Select from the buffer the closest pack (w.r.t. time stamp), 57 * respecting a defined time tolerances 58 */ 59 T select(const TimeStamp& _time_stamp, const Scalar& _time_tolerance); 60 61 T selectFirstBefore(const TimeStamp& _time_stamp, const Scalar& _time_tolerance); 62 63 /**\brief Buffer size 64 * 65 */ 66 SizeStd size(void); 67 68 /**\brief Add a pack to the buffer 69 * 70 */ 71 void add(const T& _element, const TimeStamp& _time_stamp); //const Scalar& _time_tolerance); I think since the container is map<TimeStamp, T> that the API for this fcn should be add(TimeStamp, T), that is, reverse the order of the input parameters. Also in other parts of WOLF we put the TimeStamp upfront other params, so this change increases the consistency throughout the library.
Edited by Joan Solà OrtegaI changed it in 402729e0
85 */ 86 bool empty(); 87 88 /**\brief Check time tolerance 89 * 90 * Check if the time distance between two time stamps is smaller than 91 * the time tolerance. 92 */ 93 bool simpleCheckTimeTolerance(const TimeStamp& _time_stamp1, const TimeStamp& _time_stamp2, const Scalar& _time_tolerance); 94 95 /**\brief Check time tolerance 96 * 97 * Check if the time distance between two time stamps is smaller than 98 * the minimum time tolerance of the two frames. 99 */ 100 bool doubleCheckTimeTolerance(const TimeStamp& _time_stamp1, const Scalar& _time_tolerance1, const TimeStamp& _time_stamp2, const Scalar& _time_tolerance2); fixed in 8a6f3135
added ~209 enhancement labels
assigned to @joanvallve
enabled an automatic merge when the pipeline for 33cee2de succeeds
mentioned in commit 6b39ccd3
Please register or sign in to reply