Small bug while calling removeUpTo in process()

The current implementation does:

PackKeyFramePtr pack = kf_pack_buffer_.selectPack( last_ptr_ , params_tracker_->time_tolerance);
kf_pack_buffer_.removeUpTo( last_ptr_->getTimeStamp() );

Consider a pack newer than last_ptr_ within the params_tracker_->time_tolerance_, in this case the removeUpTo won't remove the selected pack. Then, in a future process(), will treat the same pack as a new KF.

If the time_tolerance is properly defined (equal or lower than the time between captures), it shouldn't be a problem since this pack won't be selected ẁhile processing the next capture within the time tolerance. However, I think it is safer to ensure that we remove all the packs up to the selected one (included) since this KF has already been handled.

src/processor/processor_tracker.cpp

@@ -53,7 +53,7 @@ void ProcessorTracker::process(CaptureBasePtr const _incoming_ptr)
         case FIRST_TIME_WITH_PACK :
         {
             PackKeyFramePtr pack = kf_pack_buffer_.selectPack( incoming_ptr_, params_tracker_->time_tolerance);
-            kf_pack_buffer_.removeUpTo( incoming_ptr_->getTimeStamp() );
+            kf_pack_buffer_.removeUpTo( pack->key_frame->getTimeStamp() );
 
             WOLF_DEBUG( "PT ", getName(), ": KF" , pack->key_frame->id() , " callback unpacked with ts= " , pack->key_frame->getTimeStamp().get() );
 
@@ -124,7 +124,7 @@ void ProcessorTracker::process(CaptureBasePtr const _incoming_ptr)
         case RUNNING_WITH_PACK :
         {
             PackKeyFramePtr pack = kf_pack_buffer_.selectPack( last_ptr_ , params_tracker_->time_tolerance);
-            kf_pack_buffer_.removeUpTo( last_ptr_->getTimeStamp() );
+            kf_pack_buffer_.removeUpTo( pack->key_frame->getTimeStamp() );
 
             WOLF_DEBUG( "PT ", getName(), ": KF" , pack->key_frame->id() , " callback unpacked with ts= " , pack->key_frame->getTimeStamp().get() );