New class isMotion
To be inherited from all ProcessorMotion
and also ProcessorOdomIcp
. There should be just getCurrentState() = 0
and in the near future getOdom() = 0
.
To be inherited from all ProcessorMotion
and also ProcessorOdomIcp
. There should be just getCurrentState() = 0
and in the near future getOdom() = 0
.
added To Do (release) label
created merge request !338 (merged) to address this issue
mentioned in merge request !338 (merged)
@joanvallve what about this call to Problem::processor_motion_ptr_
?
void Problem::auxFrameCallback(FrameBasePtr _frame_ptr, ProcessorBasePtr _processor_ptr, const double& _time_tolerance)
{
if (_processor_ptr)
{
WOLF_DEBUG((_processor_ptr->isMotion() ? "PM " : "PT "), _processor_ptr->getName(), ": AuxF", _frame_ptr->id(), " Callback emitted with ts = ", _frame_ptr->getTimeStamp());
}
else
{
WOLF_DEBUG("External callback: AuxF", _frame_ptr->id(), " Callback emitted with ts = ", _frame_ptr->getTimeStamp());
}
processor_motion_ptr_->keyFrameCallback(_frame_ptr, _time_tolerance); /// <-- HERE !!!
}
It is the only case in Problem where we call stuff other than what we spoke for IsMotion.
The whole auxiliary frames functionality is not fully implemented. Actually it is not tested at all. I would comment/remove this line and whenever we have to implement and test this functionality, we'll see.
closed via merge request !338 (merged)
mentioned in commit 38083867