Resolve "New class isMotion"
Closes #281 (closed)
Merge request reports
Activity
added To Do (release) label
assigned to @jsola
added 1 commit
- 1180e69d - Add class IsMotion. Now ProcessorMotion inherits from it.
added 10 commits
-
1180e69d...4d01724a - 8 commits from branch
devel
- 44be7ce1 - Merge branch 'devel' into 281-new-class-ismotion
- c6bb755a - Use IsMotion in Problem
-
1180e69d...4d01724a - 8 commits from branch
added 2 commits
Hi @joanvallve you can have a look at this branch. It is working and it could be merged to devel, but it is still not clean in some aspects so I won't merge it.
However, if you want to make ProcessorOdomICP a motion processor, you can start a branch in
laser
and make it follow (manually) this branch and see if the design so far is useful.Note: By "cleaning", I mean that I think that most of the API of
IsMotion
should be implemented in IsMotion, and only a couple of pure virtuals should be exposed to the derived processors: how to get the state, and how to get the time stamp. The other ones are variations and should be implemented inIsmotion
and call the derived ones. This way, derived processors only have to implement a couple of pure virtuals and not 6 like now.added 1 commit
- 9536d517 - Partially implement IsMotion to reduce pure virtuals
mentioned in commit 38083867