Skip to content
Snippets Groups Projects

Hotfix odom3 d

Closed Dinesh Atchuthan requested to merge hotfix_odom3D into master

fix alignement issue in processorOdom3D

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @AtDinesh I see that you added a couple of EIGEN_MAKE_ALIGNED_OPERATOR_NEW. Are you working on a 32bit machine ?
    With 64bit machines this should not be necessary.

    It then brings the question of supporting 32bits ... @jsola @joanvallve

  • No I am not using a 32 bit machine... But I saw that this is actually already added in some classes.

    What else is needed to support 32 bits machines ?

  • Nor are you using a 32bit OS ?
    When using Eigen there are quite a few things to take into account in order for the code to works on 32bit machines. I do not have an exhaustive list but I can already point you to struct having Eigen type member(s) https: //eigen.tuxfamily.org/dox-devel/group__TopicStructHavingEigenMembers.html and stl containers of Eigen type https: //eigen.tuxfamily.org/dox-devel/group__TopicStlContainers.html.
    I'm no expert with Eigen but as far as I understood, there shouldn't be memory allocation issue on 64bit machines.

    note: sorry but I can't post links properly for I don't know what great reason thus they're pasted with a space ... ><

    Edited by Jeremie Deray
  • Hi. What is the goal of this merge request?

  • @AtDinesh could you provide some feedback for me to understand this MR? Is it really necessary?

  • THe fix was using Eigen::Ref as argument is some functions. Eigen::Ref are just likes maps.

    I am not working on a 32 bit computer but HRP2 may have 32 bits computers. I'll check this

  • I do not see the pertinence of these changes. I am about to discard this MR completely.

Please register or sign in to reply
Loading