fix corner 2D

@joanvallve can you please check this PR ?

added bug label

I only see the change "CORNER" to "CORNER 2D". For me it's ok, but I don't know exactly what would be a "CORNER 3D", that's why I though the "2D" was quite redundant".

Oh ok, the problem is that there is a mismatch with the ConstraintCorner2D which type is CORNER 2D.
So I probably should set CORNER in ConstraintCorner2D rather than the current modification ?

Ah, I didn't get you. It's a bug..? CORNER 2D seems better since as you say, the constraint is also explicit.

Usually, the string Tags for class names follows the rules:

1. Capital letters
2. Same name as derived class, without the category, e.g. LandmarkCorner2D --> "CORNER 2D"
3. Separate words with spaces, not underscores, e.g. do "POINT 2D" and not "POINT_2D".

These rules are possibly not good, I don't know. But for the moment it'd be good to stick to them.

The same rules apply when these labels are used in Factories. there, they become very important, as it is the only way we can tell a string label from a class type, so that the Factory knows exactly what are we talking about.

Therefore, in ConstraintCorner2D, the label must be "CORNER 2D".

Please update the MR accordingly and re-submit or comment, so that I can validate it.

My point was that the processor looks for CORNER while it creates (indirectly) CORNER 2D. Looks like a bug to me.
I'll double check and update the pr if necessary

Checking it myself... found a few wrong "CORNER" that I'm turning to "CORNER 2D"

added 1 commit

• e42cac69 - Fix CORNER into CORNER 2D in class labels

Compare with previous version

merged

mentioned in commit 7fbde899