Protect the branch 'master'

Created by: joansola

Hello,

I have protected the master branch so that only me can push there.

Usually, you should do your job in other branches, eventually in forked projects.

To contribute to master, you must send pull requests. First, merge master to your branch, and check that everything goes fine:

git checkout my_branch
git merge master
make   --> be sure you compile
../bin/test_xxx  --> execute some tests

and when you are sure everything is OK, do a pull request so that I can merge your branch to master.

I hope this works fine.

Created by: joanvallve

We should agree on some tests that should be mandatory to run before the pull request and the output of those tests.

@jsola Since the migration on Gitlab the master branch isn't protected anymore.

Status changed to reopened

done

Status changed to closed

Status changed to reopened

@jsola @joanvallve I'm obliged to re-open this issue as it seems that due to permission level a protected branch still can be pushed to. The whole point of having a protected branch is that the main branch, the master branch, the one that we all have in common despite our local changes should be kept clean and 'working'. By working I mean, as for now, that any changes to it should pass by a merge request assigned to another developer and reviewed by one or more - until a stabilized API and proper unit tests implemented (!82 (merged)).

Already working according to git-flow. Closing.

closed