Demos not built?

When I check the BUILD_DEMOS flag in cmake, I receive an error since there is no CMakeLists.txt in the core/demos/ folder. Does that mean that the .cpp files stored here are not used? Should'nt we put the hello_wolf files in there?

The files in demos are heavily outdated and thus are not compiled.

So should we remove them or update them? What about hello wolf?

@joanvallve @jsola discussed this a while ago but I don't know what is the status of this issue. I guess that we will update them once we release or have a more stable core?

I don't remember.. @jsola ?

added check status label

assigned to @joanvallve

assigned to @jcasals and unassigned @joanvallve

Agreements:

Remove processor, sensor, map and move hello wolf inside demos, add CMakeLists.txt @jcasals

Move import graph functionality to some "utils". Keep demo and fix it. @joanvallve

Rename analytic autodiff odom 2d comparison. Keep demo and fix it. @joanvallve

added To Do (release) label and removed check status label

Also:

Remove demo_map_yaml.cpp @jcasals

Fix hello_wolf_autoconf.cpp (it is broken, probably due to YAML parsing) @jcasals

Most topics here are addressed, except the two demos:

demo_analytic_autodiff_factor.cpp
demo_wolf_imported_graph.cpp

These files are really old. Don't know if we want to keep them. @joanvallve ?

Yes, we agreed on keeping the functionality of importing fraph files (from demo_wolf_imported_graph.cpp) and fix the comparison between analytic and autodiff odom2d factor (demo_analytic_autodiff_factor.cpp also renaming the demo)

These files are old, but recyclying them still have sense, I think.

mentioned in issue #409

new issue for these 2 demos to be recycled, closing this issue.

closed