Factor/Feature not connected to problem error message

When a process(capture) call creates a Factor, I get the following warning (numbers are arbitrary):
[warning][10:56:20] ADDING FACTOR 20 TO FEATURE 30 NOT CONNECTED WITH PROBLEM.

The line responsible for this is at line 160 of factor_base.cpp:

WOLF_WARN_COND(this->getProblem() == nullptr, "ADDING FACTOR ", this->id(), " TO FEATURE ", _ftr_ptr->id(), " NOT CONNECTED WITH PROBLEM.");
From what I understand, it means that the factor being linked to a feature does not have a reference to the problem pointer. Could it be that recent changes in core might be the cause of this problem?
By the way, I find the message a bit misleading, at first I thought that the feature did not have a reference to the problem.

It seems the condition should be this->getFeature()->getProblem() == nullptr, since in the following line we set the problem for the factor. So we really want to check the feature's pointer to problem, not the factor's.

Can you try this? Then for a definitive answer please agree with @joanvallve and/or @jcasals .

What @jsola says makes sense, but then again I didn't introduce this change so I am not sure. We need to ask @joanvallve for confirmation.

Yes, @jsola is right. Or _ftr_ptr->getProblem() == nullptr is also ok.

Actually I think _ftr_ptr->getProblem() == nullptr is better.

Fixed in !296 (merged)

closed