Reorder arguments in FrameBase constructor

include/core/frame/frame_base.h

@@ -63,10 +63,10 @@ class FrameBase : public NodeBase, public HasStateBlocks, public std::enable_sha
                   StateBlockPtr _o_ptr = nullptr,
                   StateBlockPtr _v_ptr = nullptr);
 
-        FrameBase(const std::string _frame_structure,
-                  const SizeEigen _dim,
-                  const FrameType & _tp,
+        FrameBase(const FrameType & _tp,
                   const TimeStamp& _ts,
+                  const std::string _frame_structure,
+                  const SizeEigen _dim,
                   const Eigen::VectorXd& _x);
 
         FrameBase(const FrameType & _tp,

src/frame/frame_base.cpp

@@ -89,10 +89,10 @@ FrameBase::FrameBase(const FrameType & _tp,
     }
 }
 
-FrameBase::FrameBase(const std::string _frame_structure,
-                     const SizeEigen _dim,
-                     const FrameType & _tp,
+FrameBase::FrameBase(const FrameType & _tp,
                      const TimeStamp& _ts,
+                     const std::string _frame_structure,
+                     const SizeEigen _dim,
                      const Eigen::VectorXd& _x) :
            NodeBase("FRAME", "FrameBase"),
            HasStateBlocks(_frame_structure),

src/problem/problem.cpp

@@ -329,10 +329,10 @@ FrameBasePtr Problem::emplaceFrame(FrameType _frame_key_type, //
                                    const Eigen::VectorXd& _frame_state)
 {
     auto frm = FrameBase::emplace<FrameBase>(trajectory_ptr_,
-                                             _frame_structure,
-                                             _dim,
                                              _frame_key_type,
                                              _time_stamp,
+                                             _frame_structure,
+                                             _dim,
                                              _frame_state);
     return frm;
 }

test/gtest_factor_diff_drive.cpp

@@ -160,16 +160,16 @@ class FactorDiffDriveTest : public testing::Test
 
             // frames
             F0 = FrameBase::emplace<FrameBase>(trajectory,
-                                               "PO",
-                                               2,
                                                KEY,
                                                0.0,
-                                               Vector3d(0,0,0));
-            F1 = FrameBase::emplace<FrameBase>(trajectory,
                                                "PO",
                                                2,
+                                               Vector3d(0,0,0));
+            F1 = FrameBase::emplace<FrameBase>(trajectory,
                                                KEY,
                                                1.0,
+                                               "PO",
+                                               2,
                                                Vector3d(1,0,0));
 
             // captures