Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
wolf
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
mobile_robotics
wolf_projects
wolf_lib
wolf
Commits
4201f9bc
Commit
4201f9bc
authored
6 years ago
by
PierreGtch
Browse files
Options
Downloads
Patches
Plain Diff
ProcessorLoopClosureBase : computeFeatures returns a bool
parent
b9b18869
No related branches found
No related tags found
1 merge request
!290
Resolve "ProcessorLoopClosureBase class"
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
include/core/processor/processor_loopclosure_base.h
+3
-1
3 additions, 1 deletion
include/core/processor/processor_loopclosure_base.h
src/processor/processor_loopclosure_base.cpp
+2
-2
2 additions, 2 deletions
src/processor/processor_loopclosure_base.cpp
with
5 additions
and
3 deletions
include/core/processor/processor_loopclosure_base.h
+
3
−
1
View file @
4201f9bc
...
@@ -89,8 +89,10 @@ protected:
...
@@ -89,8 +89,10 @@ protected:
*
*
* In this method you should add the capture to the keyframe if necessary
* In this method you should add the capture to the keyframe if necessary
* and add the features to the capture
* and add the features to the capture
*
* Returns a bool that tells if features were successfully created
*/
*/
virtual
void
computeFeatures
(
std
::
pair
<
FrameBasePtr
,
CaptureBasePtr
>
)
=
0
;
virtual
bool
computeFeatures
(
std
::
pair
<
FrameBasePtr
,
CaptureBasePtr
>
)
=
0
;
/** \brief Find a KF that would be a good candidate to close a loop
/** \brief Find a KF that would be a good candidate to close a loop
* if validateLoop is not overwritten, a loop will be closed with the returned candidate
* if validateLoop is not overwritten, a loop will be closed with the returned candidate
...
...
This diff is collapsed.
Click to expand it.
src/processor/processor_loopclosure_base.cpp
+
2
−
2
View file @
4201f9bc
...
@@ -28,9 +28,9 @@ void ProcessorLoopClosureBase::process(CaptureBasePtr _incoming_ptr)
...
@@ -28,9 +28,9 @@ void ProcessorLoopClosureBase::process(CaptureBasePtr _incoming_ptr)
{
{
std
::
pair
<
FrameBasePtr
,
CaptureBasePtr
>
pairKC
=
selectPairKC
();
std
::
pair
<
FrameBasePtr
,
CaptureBasePtr
>
pairKC
=
selectPairKC
();
if
(
pairKC
.
first
==
nullptr
||
pairKC
.
second
==
nullptr
)
return
;
if
(
pairKC
.
first
==
nullptr
||
pairKC
.
second
==
nullptr
)
return
;
computeFeatures
(
pairKC
);
bool
success_computeFeatures
=
computeFeatures
(
pairKC
);
if
(
voteSearchLoopClosure
(
_incoming_ptr
))
if
(
success_computeFeatures
&&
voteSearchLoopClosure
(
_incoming_ptr
))
{
{
CaptureBasePtr
capture_1
=
pairKC
.
second
;
CaptureBasePtr
capture_1
=
pairKC
.
second
;
CaptureBasePtr
capture_2
=
findLoopCandidate
(
capture_1
);
CaptureBasePtr
capture_2
=
findLoopCandidate
(
capture_1
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment