Skip to content
Snippets Groups Projects
Commit 226ca789 authored by Joan Vallvé Navarro's avatar Joan Vallvé Navarro
Browse files

Merge branch 'feature/getCovariance' into 'devel'

Removing getCovariance returning MatrixXs

In wolf, by default the solver is not computing the whole covariance matrix of the estimation. It has to be called explicitly to the solver defining which blocks are desired to be computed. Then, they are stored in `Problem` in `std::map<std::pair<StateBlockPtr, StateBlockPtr>, Eigen::MatrixXs> covariances_`;

Then, eventually when asking for a specific covariance block, this information is not stored.

In `Problem`, `LandmarkBase` and `FrameBase`, there are 2 kind of covariance getters:  
* `MatrixXs getXXXCovariance(const XXXPtr& xxx_ptr)`  
* `bool getXXXCovariance(const XXXPtr& xxx_ptr, MatrixXs& cov)`  

The first one, if the covariance block hasn't been computed returns an uninitialized matrix without returning any information about what happened. According to #145, we agreed on removing this first getters for covariance blocks implemented in the current MR.

See merge request !263
parents d5a991af 899e9ff5
No related branches found
No related tags found
1 merge request!263Removing getCovariance returning MatrixXs
Pipeline #2808 passed
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment