Skip to content
Snippets Groups Projects

ProcessorBase::selectPack() removed KF

Merged Joan Vallvé Navarro requested to merge remove_KF into devel

Addressing #180 (closed): When a KF is removed after being notified to all the processors by keyFrameCallback(), the PackKeyFrameBuffer::selectPack...() functions can provide a KF pack which is being removed (it has no StateBlocks and is unlinked from the tree).

Since the decentralized structure of the KF callbacks, handling this within FrameBase::remove() is quite complicated. I rather add a check in the selectPack() and selectPackBefore() functions. They are called by the processors to get the notified KF since the last process().

Appliying #163 (closed): Changed the implementation and the name of the function selectPackBefore() (see issue for more info).

  • All tests OK

  • Merging to devel

Merge request reports

Pipeline #2473 passed

Pipeline passed for 3a89db39 on remove_KF

Merged by Joan Solà OrtegaJoan Solà Ortega 6 years ago (Feb 6, 2019 10:36am UTC)

Loading

Pipeline #2477 passed

Pipeline passed for eade35b2 on devel

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading