add processor_ptr_ in ConstraintBase

Add ProcessorBaseWPtr processor_ptr_ in ConstraintBase.

Pointer is set at construction time, all derived classes have been updated together with processors.

ConstraintBase and derived now take argument pointers by const references rather than copy.

Bonus: A few c++11 keywords here and there.

@jsola This PR compiles on my machine. Some gtests are failing but it seems unrelated, I'm going to check if they pass on master.

All gtests in current 'master' pass without problems. They should also pass in your PR

An example of failing test:

rotations.AngleAxis_limits2
/home/jeremie/workspaces/wolf/src/wolf/src/test/gtest_rotation.cpp:370: Failure
Value of: rv.isMuchSmallerThan(1, wolf::Constants::EPS_SMALL)
  Actual: false
Expected: true

I doubt that because of this PR. Again I'm recompiling master and checking.

The same tests are failing on my machine on master... At least one of them is related to OpenCV not being found, I'll move it within the OpenCV guard.

I can't past here all error messages, I sent it to you on slack.
Would you tried running the tests on this branch on your machine ?

added 1 commit

• e0ee4d29 - Fix some processor pointers in Constraint constructors

Compare with previous version

added 2 commits

• 68db99c2 - mv _processor_ptr constructor input arg
• 4bb25864 - mv gtest_problem within OpenCV_FOUND guards

Compare with previous version

@jsola Updated accordingly to your remarks. Compiles and passes tests (well except the one mentioned).

added 1 commit

• 19925d89 - Put pointers in correct place in constructor

Compare with previous version

merged

mentioned in commit 81408bbd