Some gtests not passing

gtest_problem and gtest_processor_base fail

changed milestone to %IRI release

added bug label

vermicelle:bin jsola$ ./gtest_problem 
LandmarkFactory        <--  registered  BASE
ProcessorFactory       <--  registered  CAPTURE HOLDER
ProcessorFactory       <--  registered  DIFF DRIVE
ProcessorFactory       <--  registered  ODOM 2D
AutoConfProcessorFactory <--  registered  ODOM 2D
ProcessorFactory       <--  registered  ODOM 3D
SensorFactory          <--  registered  DIFF DRIVE
SensorFactory          <--  registered  ODOM 2D
AutoConfSensorFactory  <--  registered  ODOM 2D
SensorFactory          <--  registered  ODOM 3D
SolverFactory          <--  registered  Solver
ProcessorParamsFactory <--  registered  ODOM 3D
IntrinsicsFactory      <--  registered  ODOM 3D
[==========] Running 9 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 9 tests from Problem
[ RUN      ] Problem.create
[       OK ] Problem.create (0 ms)
[ RUN      ] Problem.Sensors
[       OK ] Problem.Sensors (0 ms)
[ RUN      ] Problem.Processor
[       OK ] Problem.Processor (0 ms)
[ RUN      ] Problem.Installers
unknown file: Failure
C++ exception with description "ProcessorFactory : Unknown type "TRACKER FEATURE DUMMY". Possibly you tried to use an unregistered creator." thrown in the test body.
[  FAILED  ] Problem.Installers (1 ms)
[ RUN      ] Problem.SetOrigin_PO_2D
[       OK ] Problem.SetOrigin_PO_2D (0 ms)
[ RUN      ] Problem.SetOrigin_PO_3D
[       OK ] Problem.SetOrigin_PO_3D (0 ms)
[ RUN      ] Problem.emplaceFrame_factory
[       OK ] Problem.emplaceFrame_factory (0 ms)
[ RUN      ] Problem.StateBlocks
unknown file: Failure
C++ exception with description "ProcessorFactory : Unknown type "TRACKER FEATURE DUMMY". Possibly you tried to use an unregistered creator." thrown in the test body.
[  FAILED  ] Problem.StateBlocks (0 ms)
[ RUN      ] Problem.Covariances
unknown file: Failure
C++ exception with description "ProcessorFactory : Unknown type "TRACKER FEATURE DUMMY". Possibly you tried to use an unregistered creator." thrown in the test body.
[  FAILED  ] Problem.Covariances (1 ms)
[----------] 9 tests from Problem (2 ms total)

[----------] Global test environment tear-down
[==========] 9 tests from 1 test case ran. (2 ms total)
[  PASSED  ] 6 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] Problem.Installers
[  FAILED  ] Problem.StateBlocks
[  FAILED  ] Problem.Covariances

vermicelle:bin jsola$ ./gtest_processor_base 
LandmarkFactory        <--  registered  BASE
ProcessorFactory       <--  registered  CAPTURE HOLDER
ProcessorFactory       <--  registered  DIFF DRIVE
ProcessorFactory       <--  registered  ODOM 2D
AutoConfProcessorFactory <--  registered  ODOM 2D
ProcessorFactory       <--  registered  ODOM 3D
SensorFactory          <--  registered  DIFF DRIVE
SensorFactory          <--  registered  ODOM 2D
AutoConfSensorFactory  <--  registered  ODOM 2D
SensorFactory          <--  registered  ODOM 3D
SolverFactory          <--  registered  Solver
ProcessorParamsFactory <--  registered  ODOM 3D
IntrinsicsFactory      <--  registered  ODOM 3D
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ProcessorBase
[ RUN      ] ProcessorBase.KeyFrameCallback
unknown file: Failure
C++ exception with description "ProcessorFactory : Unknown type "TRACKER FEATURE DUMMY". Possibly you tried to use an unregistered creator." thrown in the test body.
[  FAILED  ] ProcessorBase.KeyFrameCallback (0 ms)
[----------] 1 test from ProcessorBase (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (0 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ProcessorBase.KeyFrameCallback

 1 FAILED TEST

I did not have time to investigate. Possibly this PROC FEATURE DUMMY is deprecated?

Uhm funny enough these tests pass on the gitlab CI...

Maybe it's just my Mac. Please comment here.

I have pulled from devel and all tests pass. Maybe the Mac compiler is optimizing code away and this is another instance of issue #208?

Solution: register the conflicting processor factory at each problematic gtest file:

#include "core/processor/processor_factory.h"
namespace{
bool ProcessorTrackerFeatureDummyRegistered = wolf::ProcessorFactory::get().registerCreator("TRACKER FEATURE DUMMY", ProcessorTrackerFeatureDummy::create);
}

created merge request !306 (merged) to address this issue

mentioned in merge request !306 (merged)

closed via merge request !306 (merged)

mentioned in commit 9fa290f0