Skip to content
Snippets Groups Projects
Commit 02c57959 authored by Joan Solà Ortega's avatar Joan Solà Ortega
Browse files

Pass lmk list by reference to avoid copy

parent 6b9e082d
No related branches found
No related tags found
No related merge requests found
...@@ -38,7 +38,7 @@ LandmarkBasePtr MapBase::addLandmark(LandmarkBasePtr _landmark_ptr) ...@@ -38,7 +38,7 @@ LandmarkBasePtr MapBase::addLandmark(LandmarkBasePtr _landmark_ptr)
return _landmark_ptr; return _landmark_ptr;
} }
void MapBase::addLandmarkList(LandmarkBaseList _landmark_list) void MapBase::addLandmarkList(LandmarkBaseList& _landmark_list)
{ {
LandmarkBaseList lmk_list_copy = _landmark_list; //since _landmark_list will be empty after addDownNodeList() LandmarkBaseList lmk_list_copy = _landmark_list; //since _landmark_list will be empty after addDownNodeList()
for (LandmarkBasePtr landmark_ptr : lmk_list_copy) for (LandmarkBasePtr landmark_ptr : lmk_list_copy)
......
...@@ -27,7 +27,7 @@ class MapBase : public NodeBase, public std::enable_shared_from_this<MapBase> ...@@ -27,7 +27,7 @@ class MapBase : public NodeBase, public std::enable_shared_from_this<MapBase>
~MapBase(); ~MapBase();
virtual LandmarkBasePtr addLandmark(LandmarkBasePtr _landmark_ptr); virtual LandmarkBasePtr addLandmark(LandmarkBasePtr _landmark_ptr);
virtual void addLandmarkList(LandmarkBaseList _landmark_list); virtual void addLandmarkList(LandmarkBaseList& _landmark_list);
LandmarkBaseList& getLandmarkList(); LandmarkBaseList& getLandmarkList();
void load(const std::string& _map_file_yaml); void load(const std::string& _map_file_yaml);
......
...@@ -335,7 +335,7 @@ LandmarkBasePtr Problem::addLandmark(LandmarkBasePtr _lmk_ptr) ...@@ -335,7 +335,7 @@ LandmarkBasePtr Problem::addLandmark(LandmarkBasePtr _lmk_ptr)
return _lmk_ptr; return _lmk_ptr;
} }
void Problem::addLandmarkList(LandmarkBaseList _lmk_list) void Problem::addLandmarkList(LandmarkBaseList& _lmk_list)
{ {
getMapPtr()->addLandmarkList(_lmk_list); getMapPtr()->addLandmarkList(_lmk_list);
} }
......
...@@ -193,7 +193,7 @@ class Problem : public std::enable_shared_from_this<Problem> ...@@ -193,7 +193,7 @@ class Problem : public std::enable_shared_from_this<Problem>
MapBasePtr addMap(MapBasePtr _map_ptr); MapBasePtr addMap(MapBasePtr _map_ptr);
MapBasePtr getMapPtr(); MapBasePtr getMapPtr();
LandmarkBasePtr addLandmark(LandmarkBasePtr _lmk_ptr); LandmarkBasePtr addLandmark(LandmarkBasePtr _lmk_ptr);
void addLandmarkList(LandmarkBaseList _lmk_list); void addLandmarkList(LandmarkBaseList& _lmk_list);
void loadMap(const std::string& _filename_dot_yaml); void loadMap(const std::string& _filename_dot_yaml);
void saveMap(const std::string& _filename_dot_yaml, const std::string& _map_name = "Map automatically saved by Wolf"); void saveMap(const std::string& _filename_dot_yaml, const std::string& _map_name = "Map automatically saved by Wolf");
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment