code guidelines

src/loop_closure_falko.h

@@ -110,10 +110,10 @@ public:
     auto scan_falko =
     convert2LaserScanFALKO(_scan, _scan_params);
     // Extract keypoints
-    extract(*scan_falko, (new_scene->keypointsList));
+    extract(*scan_falko, (new_scene->keypoints_list_));
     // Compute descriptors
-    extractor_.compute(*scan_falko, new_scene->keypointsList,
-                       new_scene->descriptorsList);
+    extractor_.compute(*scan_falko, new_scene->keypoints_list_,
+                       new_scene->descriptors_list_);
     return new_scene;
   }
 
@@ -136,7 +136,7 @@ public:
                                  sceneFalkoBSCPtr _scene2) {
     std::vector<std::pair<int, int>> asso_nn;
     int matching_number =
-      matcher_.match(_scene1->keypointsList, _scene2->keypointsList, asso_nn);
+      matcher_.match(_scene1->keypoints_list_, _scene2->keypoints_list_, asso_nn);
     auto new_match = std::make_shared<matchLoopClosure<D>>();
     new_match->keypointsNumberMatch = matching_number;
     if (matching_number > keypoints_number_th_) {

src/scene_falko.h

@@ -33,8 +33,8 @@
 namespace laserscanutils {
 
 template <typename D> struct sceneFalko : public sceneBase {
-  std::vector<falkolib::FALKO> keypointsList;
-  std::vector<D> descriptorsList;
+  std::vector<falkolib::FALKO> keypoints_list_;
+  std::vector<D> descriptors_list_;
 };
 
 } /* namespace laserscanutils */

test/gtest_loop_closure_falko.cpp

@@ -27,8 +27,8 @@ TEST(loop_closure_falko, TestLoopClosureFalkoAllFunctions) {
   
   // Test extractScene
   auto new_scene = loop_cl_falko.extractScene(scan, laser_params);
-  int detectedKeypoints = new_scene->keypointsList.size();
-  int detectedDescriptors = new_scene->descriptorsList.size();
+  int detectedKeypoints = new_scene->keypoints_list_.size();
+  int detectedDescriptors = new_scene->descriptors_list_.size();
   ASSERT_EQ(detectedKeypoints, 18);
   ASSERT_EQ(detectedDescriptors, 18);