after cmake refactor

test/gtest/CMakeLists.txt

@@ -5,16 +5,8 @@ if(${CMAKE_VERSION} VERSION_LESS "3.11.0")
   include(ExternalProject)
 
   set(GTEST_FORCE_SHARED_CRT ON)
-  set(GTEST_DISABLE_PTHREADS OFF)
-
-  # For some reason I need to disable PTHREADS
-  # with g++ (Ubuntu 4.9.3-8ubuntu2~14.04) 4.9.3
-  # This is a known issue for MinGW :
-  # https://github.com/google/shaderc/pull/174
-  #if(MINGW)
-  #    set(GTEST_DISABLE_PTHREADS ON)
-  #endif()
-
+  set(GTEST_DISABLE_PTHREADS ON) # without this in ubuntu 18.04 we get linking errors
+  
   # Download GoogleTest
   ExternalProject_Add(googletest
       GIT_REPOSITORY https://github.com/google/googletest.git
@@ -64,6 +56,7 @@ else()
     GIT_TAG main)
 
   #FetchContent_MakeAvailable(googletest)
+  # Disable installation of googletest: https://stackoverflow.com/questions/65527126/disable-install-for-fetchcontent
   FetchContent_GetProperties(googletest)
   if(NOT googletest_POPULATED)
     FetchContent_Populate(googletest)