Skip to content
Snippets Groups Projects
  1. Nov 11, 2018
  2. Nov 08, 2018
  3. Oct 05, 2018
  4. Aug 25, 2018
  5. Jul 09, 2018
    • Ian Stapleton Cordasco's avatar
      Add heroku-18 to our Travis CI config · 2d290e94
      Ian Stapleton Cordasco authored
      - Add stage to Travis CI config and update tests.sh script to recognize
        it
      
      - Update tests to assert there is no Python 2 on Heroku-18
      
      - Update nltk fixture to use Python 3.6 so we can test it on all stacks
      
      Closes gh-730
      2d290e94
  6. Jun 28, 2018
  7. May 24, 2018
  8. May 02, 2018
  9. May 01, 2018
  10. Apr 26, 2018
  11. Mar 14, 2018
  12. Jan 08, 2018
  13. Dec 15, 2017
  14. Nov 22, 2017
  15. Sep 26, 2017
  16. Sep 08, 2017
  17. Sep 05, 2017
    • Ed Morley's avatar
      Tests: Make assertCaptured test failures easier to debug (#461) · fedae5ce
      Ed Morley authored
      Previously the contents of the file being searched was not output,
      making it hard to know how to fix a test so that it would pass.
      
      Before:
      ```
      $ make test-heroku-16
      ...
      testCffi
      ASSERT:Expected </tmp/shunit.ayVGAO/tmp/output.6gMs/stdout> to contain <ZZZZZZZ>
      testPylibmc
      ```
      
      After:
      ```
      $ make test-heroku-16
      ...
      testCffi
      ASSERT:Expected </tmp/shunit.FXWeuI/tmp/output.7Vfx/stdout> to contain <ZZZZZZZ>
       !     Warning: Your application is missing a Procfile. This file tells Heroku how to run your application.
       !     Learn more: https://devcenter.heroku.com/articles/procfile
      -----> Installing python-3.6.2
      -----> Installing pip
      -----> Installing requirements with pip
             Collecting cffi (from -r /tmp/testBoLG0/requirements.txt (line 1))
               Downloading cffi-1.10.0-cp36-cp36m-manylinux1_x86_64.whl (406kB)
             Collecting pycparser (from cffi->-r /tmp/testBoLG0/requirements.txt (line 1))
               Downloading pycparser-2.18.tar.gz (245kB)
             Installing collected packages: pycparser, cffi
               Running setup.py install for pycparser: started
                 Running setup.py install for pycparser: finished with status 'done'
             Successfully installed cffi-1.10.0 pycparser-2.18
      
      testPylibmc
      ```
      fedae5ce
    • Ed Morley's avatar
      NLTK support: Fix passing of multiple corpora identifiers (#460) · 4212e063
      Ed Morley authored
      * NLTK support: Update test to use multiple corpora
      
      So that the incorrect handling of multiple IDs seen in #444 would
      have been caught.
      
      Also switches to some of the smaller corpora, to reduce time spent
      downloading during tests (see sizes on http://www.nltk.org/nltk_data/).
      
      * NLTK support: Fix passing of multiple corpora identifiers
      
      As part of fixing the shellcheck warnigns in #438, double quotes had
      been placed around `$nltk_packages` passed to the `nltk.downloader`,
      which causes multiple identifiers to be treated as though it were just
      one identifier that contains spaces.
      
      The docs for the shellcheck warning in question recommend using arrays
      if the intended behaviour really is to split on spaces:
      https://github.com/koalaman/shellcheck/wiki/SC2086#exceptions
      
      As such, `readarray` has been used, which is present in bash >=4.
      The `[*]` array form is used in the log message, to prevent shellcheck
      warning SC2145, whereas `[@]` is used when passed to `nltk.downloader`
      to ensure the array elements are unpacked as required.
      
      Note: Both before and after this fix, using anything but unix line
      endings in `nltk.txt` will also cause breakage.
      4212e063
  18. Aug 08, 2017
    • Ed Morley's avatar
      Improve UX when clearing cache due to the stack changing (#442) · c029e44d
      Ed Morley authored
      * Test that the cache is invalidated when the stack changes
      
      * Improve UX when clearing cache due to the stack changing
      
      Now outputs a message informing that the cache was cleared, and
      clears the cache first to avoid a redundant message about removing
      an old Python version.
      c029e44d
  19. Aug 03, 2017
  20. Jun 20, 2017
  21. Jun 14, 2017
  22. Jun 05, 2017
  23. May 25, 2017
    • Ed Morley's avatar
      Make assertCapturedSuccess display stdout if stderr was empty (#390) · 7a579e4e
      Ed Morley authored
      In cases where there is no stderr there was previously no output,
      which made it hard to find the cause. The assertion messages have
      also been adjusted to remove the repetition (shunit2 already outputs
      expected vs actual itself).
      
      Before:
      ```
      testPipenv
      ASSERT:Expected captured exit code to be 0; was <2> expected:<0> but was:<2>
      testPipenvVersion
      ```
      
      After:
      ```
      testPipenv
      ASSERT:Captured exit code - expected:<0> but was:<2>
       !     Warning: Your application is missing a Procfile. This file tells Heroku how to run your application.
       !     Learn more: https://devcenter.heroku.com/articles/procfile
      -----> Installing python-2.7.13
      -----> Installing pip
      -----> Generating 'requirements.txt' with pipenv
      
      testPipenvVersion
      ```
      
      Fixes #389.
      7a579e4e
  24. Mar 16, 2017
  25. Mar 14, 2017
Loading