- Sep 08, 2017
-
-
Ed Morley authored
* Add a test for the cryptography (cffi) compile step Since it's currently untested. * Skip vendoring libffi/libmemcached on Heroku-16 Unlike for Cedar-14, Heroku-16 comes with these packages pre-installed: https://github.com/heroku/stack-images/blob/5a341970cfc1f201014262ad64c3b3e47514f663/heroku-16/installed-packages.txt#L111 https://github.com/heroku/stack-images/blob/5a341970cfc1f201014262ad64c3b3e47514f663/heroku-16/installed-packages.txt#L172 As such the build scripts had already been made a no-op on Heroku-16: https://github.com/heroku/heroku-buildpack-python/blob/fedae5ceda5a42f594012f911c3808dd5dc6fd9e/builds/libraries/vendor/libffi#L6-L9 https://github.com/heroku/heroku-buildpack-python/blob/fedae5ceda5a42f594012f911c3808dd5dc6fd9e/builds/libraries/vendor/libmemcache#L6-L9 ...meaning the Heroku-16 archives for them on S3 contain zero files. However until now, the buildpack was still unnecessarily downloading and extracting these empty archives - and not just on the first compile (like on cedar-14), but every compile since the directory check will never succeed.
-
- Sep 05, 2017
-
-
Ed Morley authored
* NLTK support: Update test to use multiple corpora So that the incorrect handling of multiple IDs seen in #444 would have been caught. Also switches to some of the smaller corpora, to reduce time spent downloading during tests (see sizes on http://www.nltk.org/nltk_data/). * NLTK support: Fix passing of multiple corpora identifiers As part of fixing the shellcheck warnigns in #438, double quotes had been placed around `$nltk_packages` passed to the `nltk.downloader`, which causes multiple identifiers to be treated as though it were just one identifier that contains spaces. The docs for the shellcheck warning in question recommend using arrays if the intended behaviour really is to split on spaces: https://github.com/koalaman/shellcheck/wiki/SC2086#exceptions As such, `readarray` has been used, which is present in bash >=4. The `[*]` array form is used in the log message, to prevent shellcheck warning SC2145, whereas `[@]` is used when passed to `nltk.downloader` to ensure the array elements are unpacked as required. Note: Both before and after this fix, using anything but unix line endings in `nltk.txt` will also cause breakage.
-
- Aug 03, 2017
-
-
Kenneth Reitz authored
* fixed the bug for pypy-5.8.0 * enable shellcheck in makefile Signed-off-by:
Kenneth Reitz <me@kennethreitz.org> * make compile script shellcheck compatible Signed-off-by:
-
Kenneth Reitz authored
* fixed the bug for pypy-5.8.0 * cleanup makefile Signed-off-by:
-
- Jun 20, 2017
-
-
Kenneth Reitz authored
* update default python to 3.6.1 * v110 * nltk python2
-
- Jun 05, 2017
-
-
Kenneth Reitz authored
-
- Mar 14, 2017
-
-
Kenneth Reitz authored
-
Kenneth Reitz authored
-
Kenneth Reitz authored
-
Kenneth Reitz authored
-
Kenneth Reitz authored
-
Kenneth Reitz authored
-
- Mar 10, 2017
-
-
Kenneth Reitz authored
-
Kenneth Reitz authored
-
- Mar 08, 2017
-
-
Kenneth Reitz authored
-
- Mar 07, 2017
-
-
Kenneth Reitz authored
-
- Feb 01, 2017
-
-
Kenneth Reitz authored
-
- Jan 25, 2017
-
-
Kenneth Reitz authored
-
Kenneth Reitz authored
-
