More complete print()

There are some relevant informations that could be printed in print():

• Address of state blocks (it's the way we can identify them, useful for debugging, maybe we need an id?)
• If is_removing_
• For StateBlocks and Factors, if they are in the solver or not (that could be indirectly checked via notification list in problem).

added Agreement required label

mentioned in issue #363

(@jsola's comment)

You mean using the state_blocks API option? Yes, it makes sense.

Just one comment. Print() outcome is huge. It is important to keep the result readable as far as possible. I tried to achieve this, perhaps unfortunatedly at times, and two of my rules are:

• Use tabulated output as much as possible
• Use short names

So for the SB pointer, it's good if this info

• comes just after the 'KEY', to keep tabulation, that is before any other info which can have differing lengths,
• and also perhaps to cut out the first part of the address which is common to all pointers (usually only the last 4 digits are of any interest).

Also, in FactorBase::printHeader we have:

 _stream << _tabs << "Fac" << id() << " " << getType() << " -->";
    if (       getFrameOtherList()   .empty()
               && getCaptureOtherList() .empty()
               && getFeatureOtherList() .empty()
               && getLandmarkOtherList().empty())
        _stream << " Abs";

    for (const auto& Fow : getFrameOtherList())
        if (!Fow.expired())
            _stream << " Frm" << Fow.lock()->id();
    for (const auto& Cow : getCaptureOtherList())
        if (!Cow.expired())
            _stream << " Cap" << Cow.lock()->id();
    for (const auto& fow : getFeatureOtherList())
        if (!fow.expired())
            _stream << " Ftr" << fow.lock()->id();
    for (const auto& Low : getLandmarkOtherList())
        if (!Low.expired())
            _stream << " Lmk" << Low.lock()->id();
    _stream << std::endl;

Instead, we could return the topology info (std::string getTopology() returns "ABS","MOTION","LOOP","LMK","GEOM,"UNDEFINED","OTHER") or both?

Yes, I agree! I think both:

    Fac1 FactorXxxx LMK --> Frm2 Cap3 Ftr4 Lmk5

changed the description

marked the checklist item Address of state blocks (it's the way we can identify them, useful for debugging, maybe we need an id?) as completed