From d392a3152f58710f6f768ba3075b566c728ecae7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joan=20Sol=C3=A0?= <jsola@iri.upc.edu>
Date: Mon, 18 Sep 2023 16:30:56 +0200
Subject: [PATCH] remove unnecessary if()

---
 test/gtest_processor_landmark_external.cpp | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/test/gtest_processor_landmark_external.cpp b/test/gtest_processor_landmark_external.cpp
index c7ac5c831..f97df2721 100644
--- a/test/gtest_processor_landmark_external.cpp
+++ b/test/gtest_processor_landmark_external.cpp
@@ -296,17 +296,17 @@ void ProcessorLandmarkExternalTest::testConfiguration(int dim,
             ASSERT_FALSE(fac_list.empty());
             
             // factors' type
-            if (should_emplace_KF)
-                for (auto fac : fac_list)
+            for (auto fac : fac_list)
+            {
+                if (fac->getProcessor() == processor)
                 {
-                    if (fac->getProcessor() == processor)
-                    {
-                        ASSERT_EQ(fac->getType(), std::string("FactorRelative") + 
-                                                  (orientation ? "Pose" : "Position") + 
-                                                  (dim == 2 ? "2d" : "3d") + 
-                                                  "WithExtrinsics");
-                    }
+                    ASSERT_EQ(fac->getType(), std::string("FactorRelative") + 
+                                                (orientation ? "Pose" : "Position") + 
+                                                (dim == 2 ? "2d" : "3d") + 
+                                                "WithExtrinsics");
                 }
+            }
+
             // landmarks created by processor
             if (not add_landmarks)
             {
-- 
GitLab