From 6d79d11acd7c276128cb81192685b334eab04693 Mon Sep 17 00:00:00 2001
From: Joan Sola <jsola@iri.upc.edu>
Date: Wed, 26 Feb 2020 13:24:26 +0100
Subject: [PATCH] remove commented code

---
 include/core/feature/feature_base.h |  4 ----
 src/feature/feature_base.cpp        | 22 ----------------------
 2 files changed, 26 deletions(-)

diff --git a/include/core/feature/feature_base.h b/include/core/feature/feature_base.h
index 8964df792..1eb9bd338 100644
--- a/include/core/feature/feature_base.h
+++ b/include/core/feature/feature_base.h
@@ -101,10 +101,6 @@ class FeatureBase : public NodeBase, public std::enable_shared_from_this<Feature
         static std::shared_ptr<classType> emplace(CaptureBasePtr _cpt_ptr, T&&... all);
 
 
-//    protected:
-//
-//        Eigen::MatrixXd computeSqrtUpper(const Eigen::MatrixXd& _M) const;
-
     private:
         void setCapture(CaptureBasePtr _cap_ptr){capture_ptr_ = _cap_ptr;}
         FactorBasePtr addFactor(FactorBasePtr _co_ptr);
diff --git a/src/feature/feature_base.cpp b/src/feature/feature_base.cpp
index 68ddcba42..df5d1f1e7 100644
--- a/src/feature/feature_base.cpp
+++ b/src/feature/feature_base.cpp
@@ -134,28 +134,6 @@ void FeatureBase::setProblem(ProblemPtr _problem)
         fac->setProblem(_problem);
 }
 
-//Eigen::MatrixXd FeatureBase::computeSqrtUpper(const Eigen::MatrixXd & _info) const
-//{
-//    // impose symmetry
-//    Eigen::MatrixXd info = _info.selfadjointView<Eigen::Upper>();
-//
-//    // Normal Cholesky factorization
-//    Eigen::LLT<Eigen::MatrixXd> llt_of_info(info);
-//    Eigen::MatrixXd R = llt_of_info.matrixU();
-//
-//    // Good factorization
-//    if (info.isApprox(R.transpose() * R, Constants::EPS))
-//        return R;
-//
-//    // Not good factorization: SelfAdjointEigenSolver
-//    Eigen::SelfAdjointEigenSolver<Eigen::MatrixXd> es(info);
-//    Eigen::VectorXd eval = es.eigenvalues().real().cwiseMax(Constants::EPS);
-//
-//    R = eval.cwiseSqrt().asDiagonal() * es.eigenvectors().real().transpose();
-//
-//    return R;
-//}
-
 void FeatureBase::link(CaptureBasePtr _cpt_ptr)
 {
     assert(!is_removing_ && "linking a removed feature");
-- 
GitLab