From 5ee4fc76eeab4c1e5bd2f94ce3d2b2e49c9acf59 Mon Sep 17 00:00:00 2001
From: Joan Sola <jsola@iri.upc.edu>
Date: Mon, 19 Feb 2018 19:31:35 +0100
Subject: [PATCH] Make time tolerances not affect the test
---
src/test/gtest_processor_base.cpp | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/test/gtest_processor_base.cpp b/src/test/gtest_processor_base.cpp
index 427713572..8a7afda6e 100644
--- a/src/test/gtest_processor_base.cpp
+++ b/src/test/gtest_processor_base.cpp
@@ -147,6 +147,8 @@ TEST_F(KFPackBufferTest, selectPack)
TEST_F(KFPackBufferTest, removeUpTo)
{
+ // Small time tolerance for all test asserts
+ Scalar tt = 0.1;
kfpackbuffer.clear();
kfpackbuffer.add(f10, tt10);
kfpackbuffer.add(f20, tt20);
@@ -157,9 +159,9 @@ TEST_F(KFPackBufferTest, removeUpTo)
KFPackPtr pack20 = std::make_shared<KFPack>(f20,tt20);
kfpackbuffer.removeUpTo( pack20->key_frame->getTimeStamp() );
ASSERT_EQ(kfpackbuffer.size(),1);
- ASSERT_TRUE(kfpackbuffer.selectPack(f10->getTimeStamp(),tt10)==nullptr);
- ASSERT_TRUE(kfpackbuffer.selectPack(f20->getTimeStamp(),tt20)==nullptr);
- ASSERT_TRUE(kfpackbuffer.selectPack(f21->getTimeStamp(),tt21)!=nullptr);
+ ASSERT_TRUE(kfpackbuffer.selectPack(f10->getTimeStamp(),tt)==nullptr);
+ ASSERT_TRUE(kfpackbuffer.selectPack(f20->getTimeStamp(),tt)==nullptr);
+ ASSERT_TRUE(kfpackbuffer.selectPack(f21->getTimeStamp(),tt)!=nullptr);
// Chech removal of an imprecise time stamp
// Specifically, only f28 should remain
@@ -169,8 +171,8 @@ TEST_F(KFPackBufferTest, removeUpTo)
KFPackPtr pack22 = std::make_shared<KFPack>(f22,5);
kfpackbuffer.removeUpTo( pack22->key_frame->getTimeStamp() );
ASSERT_EQ(kfpackbuffer.size(),1);
- ASSERT_TRUE(kfpackbuffer.selectPack(f21->getTimeStamp(),tt21)==nullptr);
- ASSERT_TRUE(kfpackbuffer.selectPack(f28->getTimeStamp(),tt28)!=nullptr);
+ ASSERT_TRUE(kfpackbuffer.selectPack(f21->getTimeStamp(),tt)==nullptr);
+ ASSERT_TRUE(kfpackbuffer.selectPack(f28->getTimeStamp(),tt)!=nullptr);
}
--
GitLab