From fa7465b5dc10c242a0e74f2da84a8998754208eb Mon Sep 17 00:00:00 2001
From: fherrero <fherrero@iri.upc.edu>
Date: Mon, 7 Dec 2020 11:46:05 +0100
Subject: [PATCH] Constructor name passed by value, not reference
---
include/model_car_drivers_act.h | 2 +-
include/model_car_drivers_base.h | 2 +-
include/model_car_drivers_bat.h | 6 +++---
include/model_car_drivers_egomotion.h | 2 +-
include/model_car_drivers_uss.h | 2 +-
src/model_car_drivers_act.cpp | 2 +-
src/model_car_drivers_base.cpp | 2 +-
src/model_car_drivers_bat.cpp | 2 +-
src/model_car_drivers_egomotion.cpp | 2 +-
src/model_car_drivers_uss.cpp | 2 +-
10 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/include/model_car_drivers_act.h b/include/model_car_drivers_act.h
index 11e024f..df0fa22 100644
--- a/include/model_car_drivers_act.h
+++ b/include/model_car_drivers_act.h
@@ -29,7 +29,7 @@ class CModel_Car_Drivers_Act: public CModel_Car_Drivers_Base
protected:
public:
- CModel_Car_Drivers_Act(std::string &name);
+ CModel_Car_Drivers_Act(std::string name);
void send_speed(float speed);
void send_steering(float angle);
void send_watchdog();
diff --git a/include/model_car_drivers_base.h b/include/model_car_drivers_base.h
index 0af5fff..e0cb86d 100644
--- a/include/model_car_drivers_base.h
+++ b/include/model_car_drivers_base.h
@@ -62,7 +62,7 @@ class CModel_Car_Drivers_Base
void delete_thread_and_events(void);
public:
- CModel_Car_Drivers_Base(std::string &name, ARDUINO_ID arduino_id);
+ CModel_Car_Drivers_Base(std::string name, ARDUINO_ID arduino_id);
void start();
bool open(std::string &serial_dev);
void stop(void);
diff --git a/include/model_car_drivers_bat.h b/include/model_car_drivers_bat.h
index e0d5c20..db898b7 100644
--- a/include/model_car_drivers_bat.h
+++ b/include/model_car_drivers_bat.h
@@ -1,5 +1,5 @@
-#ifndef _MODEL_CAR_DRIVERS_USS_H
-#define _MODEL_CAR_DRIVERS_USS_H
+#ifndef _MODEL_CAR_DRIVERS_BAT_H
+#define _MODEL_CAR_DRIVERS_BAT_H
#include "rs232.h"
#include "commexceptions.h"
@@ -30,7 +30,7 @@ class CModel_Car_Drivers_Bat: public CModel_Car_Drivers_Base
protected:
public:
- CModel_Car_Drivers_Bat(std::string &name);
+ CModel_Car_Drivers_Bat(std::string name);
bool get_bat(SENSOR_ID id, float & value);
~CModel_Car_Drivers_Bat(void);
};
diff --git a/include/model_car_drivers_egomotion.h b/include/model_car_drivers_egomotion.h
index 9fcb0bc..1991171 100644
--- a/include/model_car_drivers_egomotion.h
+++ b/include/model_car_drivers_egomotion.h
@@ -32,7 +32,7 @@ class CModel_Car_Drivers_Egomotion: public CModel_Car_Drivers_Base
protected:
public:
- CModel_Car_Drivers_Egomotion(std::string &name);
+ CModel_Car_Drivers_Egomotion(std::string name);
bool get_left_wheel(tSensWheelData & data);
bool get_right_wheel(tSensWheelData & data);
bool get_imu(tImuData & data);
diff --git a/include/model_car_drivers_uss.h b/include/model_car_drivers_uss.h
index 82b77ca..3883e06 100644
--- a/include/model_car_drivers_uss.h
+++ b/include/model_car_drivers_uss.h
@@ -30,7 +30,7 @@ class CModel_Car_Drivers_Uss: public CModel_Car_Drivers_Base
protected:
public:
- CModel_Car_Drivers_Uss(std::string &name);
+ CModel_Car_Drivers_Uss(std::string name);
bool get_uss(SENSOR_ID id, float & value);
~CModel_Car_Drivers_Uss(void);
};
diff --git a/src/model_car_drivers_act.cpp b/src/model_car_drivers_act.cpp
index 4904942..e3335af 100644
--- a/src/model_car_drivers_act.cpp
+++ b/src/model_car_drivers_act.cpp
@@ -1,6 +1,6 @@
#include "model_car_drivers_act.h"
-CModel_Car_Drivers_Act::CModel_Car_Drivers_Act(std::string &name) : CModel_Car_Drivers_Base(name, ARDUINO_CENTER_ACTUATORS)
+CModel_Car_Drivers_Act::CModel_Car_Drivers_Act(std::string name) : CModel_Car_Drivers_Base(name, ARDUINO_CENTER_ACTUATORS)
{
}
diff --git a/src/model_car_drivers_base.cpp b/src/model_car_drivers_base.cpp
index ef8a7ac..b9236c2 100644
--- a/src/model_car_drivers_base.cpp
+++ b/src/model_car_drivers_base.cpp
@@ -28,7 +28,7 @@ inline HexCharStruct hex(unsigned char _c)
return HexCharStruct(_c);
}
-CModel_Car_Drivers_Base::CModel_Car_Drivers_Base(std::string &name, ARDUINO_ID arduino_id)
+CModel_Car_Drivers_Base::CModel_Car_Drivers_Base(std::string name, ARDUINO_ID arduino_id)
{
this->name=name;
this->arduino_id=arduino_id;
diff --git a/src/model_car_drivers_bat.cpp b/src/model_car_drivers_bat.cpp
index 85503f0..ab14f91 100644
--- a/src/model_car_drivers_bat.cpp
+++ b/src/model_car_drivers_bat.cpp
@@ -1,6 +1,6 @@
#include "model_car_drivers_bat.h"
-CModel_Car_Drivers_Bat::CModel_Car_Drivers_Bat(std::string &name) : CModel_Car_Drivers_Base(name, ARDUINO_CENTER_MEASUREMENT)
+CModel_Car_Drivers_Bat::CModel_Car_Drivers_Bat(std::string name) : CModel_Car_Drivers_Base(name, ARDUINO_CENTER_MEASUREMENT)
{
tVoltageData v;
m_bat_values.insert(std::make_pair(ID_ARD_SENS_VOLT_ACTUATOR, v));
diff --git a/src/model_car_drivers_egomotion.cpp b/src/model_car_drivers_egomotion.cpp
index bc58ad8..13f20c8 100644
--- a/src/model_car_drivers_egomotion.cpp
+++ b/src/model_car_drivers_egomotion.cpp
@@ -1,6 +1,6 @@
#include "model_car_drivers_egomotion.h"
-CModel_Car_Drivers_Egomotion::CModel_Car_Drivers_Egomotion(std::string &name) : CModel_Car_Drivers_Base(name, ARDUINO_REAR_IMU_WHEELENC)
+CModel_Car_Drivers_Egomotion::CModel_Car_Drivers_Egomotion(std::string name) : CModel_Car_Drivers_Base(name, ARDUINO_REAR_IMU_WHEELENC)
{
}
diff --git a/src/model_car_drivers_uss.cpp b/src/model_car_drivers_uss.cpp
index 46f61ea..cbb1a34 100644
--- a/src/model_car_drivers_uss.cpp
+++ b/src/model_car_drivers_uss.cpp
@@ -1,6 +1,6 @@
#include "model_car_drivers_uss.h"
-CModel_Car_Drivers_Uss::CModel_Car_Drivers_Uss(std::string &name) : CModel_Car_Drivers_Base(name, ARDUINO_REAR_US)
+CModel_Car_Drivers_Uss::CModel_Car_Drivers_Uss(std::string name) : CModel_Car_Drivers_Base(name, ARDUINO_REAR_US)
{
tUsData us;
m_uss_values.insert(std::make_pair(ID_ARD_SENS_US_SIDE_RIGHT, us));
--
GitLab