From ef1f7f69246cdc9bf37e575c854c5bf175d45442 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez <email@josediazgonzalez.com> Date: Wed, 31 Oct 2018 16:59:04 -0400 Subject: [PATCH] fix: drop broken version check Due to how the version checks work - via sorting, not actual comparison - this previously resulted in _always_ installing sqlite3, even though it was already bundled for lower versions of python. The second version check also encompasses 3.7.0+, so there is no need to respecify the check. --- bin/utils | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bin/utils b/bin/utils index 4d1b7862..f625645d 100755 --- a/bin/utils +++ b/bin/utils @@ -93,6 +93,5 @@ python_sqlite3_check() { MIN_PYTHON_2="python-2.7.15" ( python2_check "$VERSION" && version_gte "$VERSION" "$MIN_PYTHON_2" ) \ - || ( python3_check "$VERSION" && version_gte "$VERSION" "$MIN_PYTHON_3" ) \ - || ( version_gte "$VERSION" "3.7.0" ) + || ( python3_check "$VERSION" && version_gte "$VERSION" "$MIN_PYTHON_3" ) } -- GitLab