From dec86fbc2e03940d1ba9a77da6edd460b42615a1 Mon Sep 17 00:00:00 2001
From: Kenneth Reitz <me@kennethreitz.org>
Date: Tue, 10 Nov 2015 12:22:33 -0500
Subject: [PATCH] explicitly error out on bad pip install

---
 bin/steps/pip-install | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/bin/steps/pip-install b/bin/steps/pip-install
index b3850178..02da2c5b 100755
--- a/bin/steps/pip-install
+++ b/bin/steps/pip-install
@@ -4,8 +4,16 @@ puts-step "Installing dependencies with pip"
 [ ! "$FRESH_PYTHON" ] && bpwatch start pip_install
 [ "$FRESH_PYTHON" ] && bpwatch start pip_install_first
 
+set +e
+
 /app/.heroku/python/bin/pip install -r requirements.txt --exists-action=w --src=./.heroku/src --allow-all-external --disable-pip-version-check --no-cache-dir | cleanup | log-output | indent
 
+if [[ "$?" ]]; then
+    echo "an error occurred."
+    exit
+fi
+set -e
+
 # Smart Requirements handling
 cp requirements.txt .heroku/python/requirements-declared.txt
 /app/.heroku/python/bin/pip freeze > .heroku/python/requirements-installed.txt
-- 
GitLab