From c732097d1763abee5952e4761205232ed0954f9a Mon Sep 17 00:00:00 2001 From: "Yury V. Zaytsev" <yury@shurup.com> Date: Mon, 19 Mar 2018 12:15:37 +0100 Subject: [PATCH] Output pipenv version in steps (#662) * Since pipenv is being pinned now, output pinned version in steps Signed-off-by: Yury V. Zaytsev <yury.zaytsev@moneymeets.com> * Update README.md example output to match new reality Signed-off-by: Yury V. Zaytsev <yury.zaytsev@moneymeets.com> * Update pipenv --- README.md | 2 +- bin/steps/pipenv | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index eab695b1..e0d609bb 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ Deploying a Python application couldn't be easier: -----> Python app detected -----> Installing python-3.6.4 -----> Installing pip - -----> Installing requirements with latest pipenv… + -----> Installing requirements with Pipenv 11.7.1… ... Installing dependencies from Pipfile… -----> Discovering process types diff --git a/bin/steps/pipenv b/bin/steps/pipenv index d1ce7c18..59aab27b 100755 --- a/bin/steps/pipenv +++ b/bin/steps/pipenv @@ -41,12 +41,14 @@ if [ ! "$SKIP_PIPENV_INSTALL" ]; then export PIP_EXTRA_INDEX_URL fi + export PIPENV_VERSION="11.8.2" + # Install pipenv. - /app/.heroku/python/bin/pip install pipenv==11.7.1 --upgrade &> /dev/null + /app/.heroku/python/bin/pip install pipenv==$PIPENV_VERSION --upgrade &> /dev/null # Install the dependencies. if [[ ! -f Pipfile.lock ]]; then - puts-step "Installing dependencies with latest Pipenv…" + puts-step "Installing dependencies with Pipenv $PIPENV_VERSION…" /app/.heroku/python/bin/pipenv install --system --skip-lock 2>&1 | indent else pipenv-to-pip Pipfile.lock > requirements.txt @@ -54,7 +56,7 @@ if [ ! "$SKIP_PIPENV_INSTALL" ]; then cp requirements.txt .heroku/python/requirements-declared.txt openssl dgst -sha256 Pipfile.lock > .heroku/python/Pipfile.lock.sha256 - puts-step "Installing dependencies with latest Pipenv…" + puts-step "Installing dependencies with Pipenv $PIPENV_VERSION…" /app/.heroku/python/bin/pipenv install --system --deploy 2>&1 | indent fi -- GitLab